Less conservative char escaping #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the !isempty check, terminal newlines as appear in
styled"stuff\
"
or similar are not eaten, and so parsed as "stuff\\\n".
This differs to the EBNF and standard string parsing (which we aim to
emulate), which parses
"stuff\
"
as "stuff".
While the !isempty check is a nice sign that I wa sbeing careful writing
the code here, it's actually safe when the state is empty, and no errors
appear in the syntax fuzzing tests.
So, all in all, it seems like we're better off without the !isempty check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104, hopefully doesn't introduce any new issues (no red flags from the fuzz test at least).
See the commit message for more details.