Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch datastructure Vector -> Set for algorithmic complexity #3652

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Switch datastructure Vector -> Set for algorithmic complexity #3652

merged 1 commit into from
Oct 13, 2023

Conversation

Keno
Copy link
Member

@Keno Keno commented Oct 12, 2023

In the same project as #3651, this code was also having trouble because of the rapidly growing alldeps, which would end up with many repeated entries. Switch the data structure to fix the algorithmic complexity here also.

@Keno
Switch datastructure Vector -> Set for algorithmic complexity
1a1aec0 
In the same project as #3651, this code was also having trouble
because of the rapidly growing alldeps, which would end up with
many repeated entries. Switch the data structure to fix the algorithmic
complexity here also.
@Keno Keno requested a review from IanButterworth October 12, 2023 22:45
IanButterworth
IanButterworth approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks

@KristofferC KristofferC merged commit 0e0cf45 into master Oct 13, 2023
11 of 13 checks passed
@KristofferC KristofferC deleted the kf/vectoset branch October 13, 2023 14:15
IanButterworth pushed a commit that referenced this pull request Oct 31, 2023
@Keno @IanButterworth
Switch datastructure Vector -> Set for algorithmic complexity (#3652)
d6c6434 
In the same project as #3651, this code was also having trouble
because of the rapidly growing alldeps, which would end up with
many repeated entries. Switch the data structure to fix the algorithmic
complexity here also.

(cherry picked from commit 0e0cf45)
@IanButterworth IanButterworth mentioned this pull request Oct 31, 2023
Merged
8 tasks
IanButterworth pushed a commit that referenced this pull request Oct 31, 2023
@Keno @IanButterworth
Switch datastructure Vector -> Set for algorithmic complexity (#3652)
c16a523 
In the same project as #3651, this code was also having trouble
because of the rapidly growing alldeps, which would end up with
many repeated entries. Switch the data structure to fix the algorithmic
complexity here also.

(cherry picked from commit 0e0cf45)
@IanButterworth IanButterworth mentioned this pull request Oct 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
precompile Pkg.precompile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keno @IanButterworth @KristofferC