Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make auto GC message use printpkgstyle #3633

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Make auto GC message use printpkgstyle #3633

merged 2 commits into from
Oct 12, 2023

Conversation

KristofferC
Copy link
Member

Fixes #3632

@IanButterworth
Copy link
Member

IanButterworth commented Oct 9, 2023 •
edited
Loading

Maybe the better fix is to turn this into a printpkgstyle? That will get captured by the precompile script, I believe? It's one of the places where Pkg logs where I think it should use the Pkg print format

IanButterworth
IanButterworth reviewed Oct 9, 2023
View reviewed changes
src/Pkg.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth changed the title hide Pkg.gc info message when precompiling Pkg Make auto GC message use printpkgstyle Oct 11, 2023
@IanButterworth IanButterworth merged commit 3ffd1cf into master Oct 12, 2023
11 of 13 checks passed
@IanButterworth IanButterworth deleted the kc/gc_log_prec branch October 12, 2023 01:05
IanButterworth pushed a commit that referenced this pull request Oct 31, 2023
@KristofferC @IanButterworth
Make auto GC message use printpkgstyle (#3633)
90716a5 
(cherry picked from commit 3ffd1cf)
@IanButterworth IanButterworth mentioned this pull request Oct 31, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extraneous misleading output during precompile statements
2 participants
@KristofferC @IanButterworth