-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing prefix for radius #135
Conversation
The failure looks like JuliaReach/LazySets.jl#3238, we need to update to LazySets v2 it seems |
LazySets does not support v0.22 of IntervalArithmetic. |
neither does ILA, so there should be no problem I think? |
IntervalConstraintProgramming.jl only supports v0.20 it seems anyway |
The documentation errors because some non-exported abstract type are not included in the docs. |
I think we can just set |
There are still other documentation failures, maybe we can merge this PR since it's unrelated and fix this in another one ? |
@lucaferranti @schillic bump :) |
Sorry! I ll sort this out tomorrow while travelling to JuliaCon (see you there if you are coming) |
Thanks! Unfortunately I won't be able to attend this year |
@blegat this is merged now, but for some reason the documentation deployment fails on main, I'll try to debug it. (Help welcome if you spot the reason) |
The error message is:
I cannot see any green checkmarks next to the commits on |
It's definitely not, but I think we still need to fix that otherwise when making a release it will not build the docs |
One should double check the setup with secret keys etc... as detailed in https://documenter.juliadocs.org/stable/man/hosting/ |
yeah it might be I messed that up at some point and went unnoticed till now |
@lucaferranti Just had the same issue when updating a package. It seems that the setup changed at some point. Try ] dev IntervalLinearAlgebra
julia> using DocumenterTools
julia> DocumenterTools.genkeys(IntervalLinearAlgebra)
┌ Info: Add the key below as a new 'Deploy key' on GitHub (https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/keys) with read and write access.
└ The 'Title' field can be left empty as GitHub can infer it from the key comment.
ssh-rsa ... Documenter
[ Info: Add a secure 'Repository secret' named 'DOCUMENTER_KEY' (to https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/secrets if you deploy using GitHub Actions) with value:
... I'm guessing that you will see that you did not have a deploy key even if you had a repo secret (that was my case). By adding a deploy key and updating the secret, I got things to work again. |
Thanks @blegat ! That indeed fixed the problem! Pretty trivial in retrospection. Now documentation is green on main, I'll tag a new patch release as soon as workflow ends |
eigenbox
is currently failing withLooking at other places where
radius
is used in the package, it seems that it's simply not exported byIntervalArithmetic
so we need an explicit prefix