Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prefix for radius #135

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Jun 14, 2024

eigenbox is currently failing with

Stacktrace:
  [1] eigenbox(A::Symmetric{Interval{Float64}, Matrix{Interval{Float64}}}, ::IntervalLinearAlgebra.Rohn)
    @ IntervalLinearAlgebra ~/.julia/packages/IntervalLinearAlgebra/2hpkP/src/eigenvalues/interval_eigenvalues.jl:51
  [2] eigenbox(A::Matrix{Interval{Float64}}, method::IntervalLinearAlgebra.Rohn)
    @ IntervalLinearAlgebra ~/.julia/packages/IntervalLinearAlgebra/2hpkP/src/eigenvalues/interval_eigenvalues.jl:95
  [3] eigenbox(A::Matrix{Interval{Float64}})
    @ IntervalLinearAlgebra ~/.julia/packages/IntervalLinearAlgebra/2hpkP/src/eigenvalues/interval_eigenvalues.jl:126

Looking at other places where radius is used in the package, it seems that it's simply not exported by IntervalArithmetic so we need an explicit prefix

@blegat
Copy link
Contributor Author

blegat commented Jun 17, 2024

The failure looks like JuliaReach/LazySets.jl#3238, we need to update to LazySets v2 it seems

@schillic
Copy link
Collaborator

LazySets does not support v0.22 of IntervalArithmetic.

@lucaferranti
Copy link
Member

LazySets does not support v0.22 of IntervalArithmetic.

neither does ILA, so there should be no problem I think?

@blegat
Copy link
Contributor Author

blegat commented Jun 17, 2024

IntervalConstraintProgramming.jl only supports v0.20 it seems anyway

@blegat
Copy link
Contributor Author

blegat commented Jun 17, 2024

The documentation errors because some non-exported abstract type are not included in the docs. autodocs does not include them because Private = false is used an option. We can either use Private = true or export these abstract types, what do you prefer ?

Project.toml Outdated Show resolved Hide resolved
@lucaferranti
Copy link
Member

The documentation errors because some non-exported abstract type are not included in the docs. autodocs does not include them because Private = false is used an option. We can either use Private = true or export these abstract types, what do you prefer ?

I think we can just set Private = true for now. I need to do some repo clean up at some point, sorry you hit all these corners

@blegat
Copy link
Contributor Author

blegat commented Jun 18, 2024

There are still other documentation failures, maybe we can merge this PR since it's unrelated and fix this in another one ?

@blegat
Copy link
Contributor Author

blegat commented Jul 6, 2024

@lucaferranti @schillic bump :)

@lucaferranti
Copy link
Member

Sorry! I ll sort this out tomorrow while travelling to JuliaCon (see you there if you are coming)

@blegat
Copy link
Contributor Author

blegat commented Jul 6, 2024

Thanks! Unfortunately I won't be able to attend this year

Project.toml Outdated Show resolved Hide resolved
@lucaferranti lucaferranti merged commit 1c1683c into JuliaIntervals:main Jul 9, 2024
11 checks passed
@lucaferranti
Copy link
Member

@blegat this is merged now, but for some reason the documentation deployment fails on main, I'll try to debug it. (Help welcome if you spot the reason)

@schillic
Copy link
Collaborator

schillic commented Jul 9, 2024

The error message is:

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I cannot see any green checkmarks next to the commits on master, so maybe this never worked? It is interesting that it worked on this fork, though. In any case, I do not see how this PR would be the cause.

@lucaferranti
Copy link
Member

In any case, I do not see how this PR would be the cause.

It's definitely not, but I think we still need to fix that otherwise when making a release it will not build the docs

@blegat
Copy link
Contributor Author

blegat commented Jul 9, 2024

One should double check the setup with secret keys etc... as detailed in https://documenter.juliadocs.org/stable/man/hosting/
I would guess this is the cause but I don't have the permission to check

@lucaferranti
Copy link
Member

yeah it might be I messed that up at some point and went unnoticed till now

@blegat
Copy link
Contributor Author

blegat commented Aug 13, 2024

@lucaferranti Just had the same issue when updating a package. It seems that the setup changed at some point. Try

] dev IntervalLinearAlgebra

julia> using DocumenterTools

julia> DocumenterTools.genkeys(IntervalLinearAlgebra)
┌ Info: Add the key below as a new 'Deploy key' on GitHub (https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/keys) with read and write access.
└ The 'Title' field can be left empty as GitHub can infer it from the key comment.

ssh-rsa ... Documenter

[ Info: Add a secure 'Repository secret' named 'DOCUMENTER_KEY' (to https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/secrets if you deploy using GitHub Actions) with value:

...

I'm guessing that you will see that you did not have a deploy key even if you had a repo secret (that was my case). By adding a deploy key and updating the secret, I got things to work again.

@lucaferranti
Copy link
Member

Thanks @blegat ! That indeed fixed the problem! Pretty trivial in retrospection.

Now documentation is green on main, I'll tag a new patch release as soon as workflow ends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants