Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the docs building on recent Julia #64

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Get the docs building on recent Julia #64

merged 1 commit into from
Apr 26, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Apr 26, 2019

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          11       11           
  Lines         636      636           
=======================================
  Hits          625      625           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce6026...0725984. Read the comment docs.

@johnnychen94
Copy link
Member

the function_reference.html page is broken due to missing docstrings #61

@timholy
Copy link
Member Author

timholy commented Apr 26, 2019

Agreed those need fixing. But since they are just warnings, I'll go ahead and merge this, just so we get updated docs (e.g., axes vs indices).

@timholy timholy merged commit 6c994e2 into master Apr 26, 2019
@timholy timholy deleted the teh/docs branch April 26, 2019 21:52
@timholy
Copy link
Member Author

timholy commented Apr 26, 2019

Deployment indeed worked (check latest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants