Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 83.48% 84.02% +0.53%
==========================================
Files 7 7
Lines 557 532 -25
==========================================
- Hits 465 447 -18
+ Misses 92 85 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompile depends on a gRPC server, and that means on either additional software or network dependencies.
Using a public server for precompile does not work on air gapped or restricted networks (see #81). I'm also not willing to increase the amount of dependencies just for precompile, perhaps that can eventually be done with an extension to take advantage of what is already installed.
Then there is also the matter of respecting user privacy. I meant to provide the precompile server endpoint as a public service, but I think many users may not be comfortable with this since it makes an outbound network connection.
For these reasons, I am removing precompile from the package. We may add it back as an extension in the future.