-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optimal_coloring #12
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 98.94% 97.65% -1.30%
==========================================
Files 5 6 +1
Lines 95 128 +33
==========================================
+ Hits 94 125 +31
- Misses 1 3 +2
☔ View full report in Codecov by Sentry. |
Hey! I have seen the PR and I'm grateful for the contribution, but I don't have time to review rn, hopefully in the coming weeks. Do you need this urgently? |
No hurry. Take your time. |
@dstahlke coming back to your PR now. The immediate goal of this package is to leverage the JuMP ecosystem and remain solver-agnostic. Do you think you might be able to translate your implementation into a JuMP formalism instead of PicoSAT? I think JuMP is starting to support constraint programming but I don't know how far they've come |
It look like ConstraintProgrammingExtensions.jl is not compatible with GraphsOptim.jl. They have conflicting version requirements for MathOptInterface. |
Then I suggest we formulate this as an integer program |
My concern with this is that it seems unusably slow. For example queens_graph(6) takes 16.5 seconds with ILP, as compared to 0.00276 seconds with PicoSAT. I'd imagine queens_graph(7) or queens_graph(8) would be out of reach with ILP. |
Good point. I will look into constraint programming in JuMP, it would be cool to have example of that too https://discourse.julialang.org/t/status-of-constraint-programming-in-jump/105580 |
Use PicoSAT to find the optimal proper coloring of a graph.