-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test bench CI PR #352
base: master
Are you sure you want to change the base?
Test bench CI PR #352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 117 117
Lines 6814 6814
=======================================
Hits 6630 6630
Misses 184 184 ☔ View full report in Codecov by Sentry. |
Unfortunately, the PostBenchmarks action from https://github.com/JuliaGraphs/Graphs.jl/blob/master/.github/workflows/postbench.yml was not triggered. |
Any idea why? |
Not sure at the moment.. But it also doesn't work in my fork so I i'll first fix it there and then make a PR here. |
0e5de8f
to
da1abbd
Compare
I got the workflow chain to work, but BenchmarkCI.jl is failing. |
Sorry that you went through all of this trouble to conclude that BenchmarkCI is not the thing for us. Let's put this on pause for now and think about what other options we have for benchmarking infrastructure. @willow-ahrens is taking over maintenance of BenchmarkTools, and one of her goals is to figure out the CI conundrum (see the announcement on Discourse). I have explained to her the limits that @filchristou and I have discovered, and she said she'd ping when she has stuff to review in this area. |
Is there a simple fix to benchmarkCI that would make it work, or do we need to rewrite it? |
Not to merge