Fix topological_sort #214
Merged
Fix topological_sort #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `topological_sort` and alias for `Graphs.topological_sort_dfs` and do not export the broken function`Graphs.Experimental.Traversals.topological_sort`
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 113 113
Lines 6531 6533 +2
=======================================
+ Hits 6363 6365 +2
Misses 168 168 |
gdalle
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphs.Experimental.Traversals.topological_sortis broken (see #213 ). This PR ensures thatGraphs.Experimental.Traversals.topological_sortis not exported anymore and makesGraphs.topological_sortan alias for
Graphs.topological_sort_by_dfs, as this function seems to work correctly.