-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add planarity test and PMFG #208
base: master
Are you sure you want to change the base?
Add planarity test and PMFG #208
Conversation
First step to fixing JuliaGraphs#153
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 97.23% 97.45% +0.21%
==========================================
Files 114 115 +1
Lines 6585 6752 +167
==========================================
+ Hits 6403 6580 +177
+ Misses 182 172 -10 |
Hey, thanks for this contribution, I think planarity is indeed something we could use. It might take a bit longer to completely review this PR, as these planarity algorithms are not known that much, so at least I need to get familiar with them again. |
@simonschoelly I think that's everything for now. I've added the docs for planarity and for the PMFG to the spanning trees page, as that's where it felt most relevant. |
This is an implementation of a planarity test and an algorithm to construct a planar maximally filtered graph, as mentioned in #153.
It is functioning and there are some basic tests for the planarity algorithm, but there are quite a few todos:
etc. etc.
This is my first pull request so feedback appreciated!