Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not quite ready for a merge, but I'm starting a PR so we have a place to discuss where to go from here, and for visibility in case someone wants to play around with it or help out.
This PR moves the Makie Support to a new package, QMLMakie, as suggested in the roadmap
and discussed in #206.
This has a number of benefits:
compat
boundsGLMakie
which breaksPackageCompiler.jl
As it is, I basically just copied the code from
makie_support.jl
verbatim and made the necessary changes injlqml
to initialize Makie Support in a separateJlCxx
module, so that can be wrapped byQMLMakie.jl
. There is still a lot of work to do beforeQMLMakie
can be registered, but simple examples already work: