Add mux and add functions for combining SignalChannels#26
Merged
Conversation
- mux: sequential channel multiplexer with optional sync (drains ch2 while forwarding ch1). Ported from WheresWaldo.jl's channel_mux. - add: element-wise addition of 2+ SignalChannels (varargs). - Both are allocation-free in steady state using pre-allocated rotating buffer slots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 71.13% 74.21% +3.08%
==========================================
Files 7 8 +1
Lines 485 543 +58
==========================================
+ Hits 345 403 +58
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mux(ch1, ch2; sync=true): Sequential channel multiplexer that forwards ch1 until closed, then ch2. Optionalsynckwarg controls whether ch2 is drained during the ch1 phase (for code phase synchronization).add(ch1, ch2, ...): Element-wise addition of 2+ SignalChannels (varargs). Errors on mismatchednum_samplesor fewer than 2 channels.channel_size + 2slots).Test plan
mux(sync/no-sync, empty channels, order preservation, type generality, error cases)add(2-channel, 3-channel varargs, multi-antenna N=2, Complex{Int16}, error cases)🤖 Generated with Claude Code