Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow complex basis vectors for now #669

Merged
merged 5 commits into from
Jan 11, 2025
Merged

fix: disallow complex basis vectors for now #669

merged 5 commits into from
Jan 11, 2025

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jan 4, 2025

  • Only allow creation of basis arrays when the eltype is a subtype of Real
  • Enforce that the pushforward fallback for derivative applied to Real inputs

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.61%. Comparing base (9b17e3e) to head (e57e7ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ifferentiationInterface/src/misc/from_primitive.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         112      112           
  Lines        5609     5610    +1     
=======================================
+ Hits         5475     5476    +1     
  Misses        134      134           
Flag Coverage Δ
DI 98.76% <93.33%> (+<0.01%) ⬆️
DIT 95.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 240e7e8 into main Jan 11, 2025
47 of 48 checks passed
@gdalle gdalle deleted the gd/nocomplexbasis branch January 11, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant