Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Enzyme gradient #515

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Optimize Enzyme gradient #515

merged 2 commits into from
Sep 30, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 30, 2024

DI extensions

Enzyme:

  • Improve gradient! by using preparation
  • Implement versions of gradient without preparation

Blocked by EnzymeAD/Enzyme.jl#1929 (I had just forgotten the activity annotation)

@gdalle gdalle linked an issue Sep 30, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (7a09754) to head (0cd1877).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   98.71%   98.70%   -0.02%     
==========================================
  Files         105      105              
  Lines        4523     4545      +22     
==========================================
+ Hits         4465     4486      +21     
- Misses         58       59       +1     
Flag Coverage Δ
DI 98.87% <100.00%> (-0.03%) ⬇️
DIT 98.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle closed this Sep 30, 2024
@gdalle gdalle reopened this Sep 30, 2024
@gdalle gdalle marked this pull request as ready for review September 30, 2024 20:16
@gdalle gdalle merged commit 73f7314 into main Sep 30, 2024
116 checks passed
@gdalle gdalle deleted the gd/better_enzyme_grad branch September 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants