Skip to content

[WIP] use new timing api #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vilterp wants to merge 3 commits into from
Closed

[WIP] use new timing api #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0de325
use new timing api
vilterp Nov 17, 2022
029b19b
remove another usage of reset_timings
vilterp Nov 18, 2022
3e19101
make precompile work in old case
vilterp Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions SnoopCompileCore/src/snoopi_deep.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,14 @@ function addchildren!(parent::InferenceTimingNode, t::Core.Compiler.Timings.Timi
end

function start_deep_timing()
Core.Compiler.Timings.reset_timings()
Core.Compiler.__set_measure_typeinf(true)
end
function stop_deep_timing()
Core.Compiler.__set_measure_typeinf(false)
Core.Compiler.Timings.close_current_timer()
end

function finish_snoopi_deep()
return InferenceTimingNode(Core.Compiler.Timings._timings[1])
return [InferenceTimingNode(tree) for tree in Core.Compiler.Timings.clear_and_fetch_timings()]
end

function _snoopi_deep(cmd::Expr)
Expand Down
31 changes: 22 additions & 9 deletions SnoopPrecompile/src/SnoopPrecompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,29 @@ macro precompile_all_calls(ex::Expr)
end
end
if have_inference_tracking
ex = quote
Core.Compiler.Timings.reset_timings()
Core.Compiler.__set_measure_typeinf(true)
try
$ex
finally
Core.Compiler.__set_measure_typeinf(false)
Core.Compiler.Timings.close_current_timer()
ex = if isdefined(Core.Compiler.Timings, :clear_and_fetch_timings)
# use new thread-safe timings API if it's available in this version of Julia
quote
Core.Compiler.__set_measure_typeinf(true)
try
$ex
finally
Core.Compiler.__set_measure_typeinf(false)
end
$SnoopPrecompile.precompile_roots(Core.Compiler.Timings.clear_and_fetch_timings())
end
else
quote
Core.Compiler.Timings.reset_timings()
Core.Compiler.__set_measure_typeinf(true)
try
$ex
finally
Core.Compiler.__set_measure_typeinf(false)
Core.Compiler.Timings.close_current_timer()
end
$SnoopPrecompile.precompile_roots(Core.Compiler.Timings._timings[1].children)
end
$SnoopPrecompile.precompile_roots(Core.Compiler.Timings._timings[1].children)
end
end
return esc(quote
Expand Down