Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 11 11
Lines 1648 1648
=======================================
Hits 1329 1329
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
To the maintainers, do you have a governance process for packages under this org? For example, is there a set of assigned maintainers to each package that can be contacted to push through changes? This particular bug is critical and needs patching for 1.12 usage. I've made a few patches myself to this package over the years and wouldn't mind being added to the maintainers list and help get changes merged in. |
Tests the specific crash scenario from issue JuliaDatabases#145 where iterating over BSON documents containing binary data would segfault on Julia 1.12. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thanks for the fix! This is a great catch - the C enum size mismatch was indeed causing stack corruption on Julia 1.12. I've pushed a test case for the specific crash scenario from #145 to ensure we don't regress. Regarding your question about governance: we'd love to have you help maintain the package! I'll follow up on getting you added as a maintainer. |
Enums in C are
int, which are 4 bytes. Using single bytes is valid for representation, but not when sharing memory across the Julia/C boundary. This seems to fix the iteration example in #145.