Use YAML version traits in the parser #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`firstmark(token)` and `lastmark(token)`.
* Performance improvement of `scan_line_break`. * Rename `scan_line_break` to `yaml_1_1_scan_line_break`. * Add `yaml_1_2_scan_line_break`. * Add better comments. * Add a TODO comment about possible bugs.
* Bug fix. * Change to use `yaml_1_1_` prefix for YAML 1.1's `forwardchars!`. * Add `yaml_1_2_forwardchars!` for YAML 1.2's `forwardchars!`. * Add some helper functions for `forwardchars!`: * `forwardchar_skip!` * `forwardchar_nobreak!` * `forwardchar_breakline!`
Change to not overbuffer. This bug fix brake the test `windows_newlines` but I think the test is incorrect.
* Sort out functions. * Add `b-char` for YAML 1.2. * Add comments to `forwardchars!`.
|
This has identical title to #228, and seems to be on the same branch. Was that unintentional duplication? Given all of the merge commits here, and the overlap with other stuff, I'm guessing this could do with a rebase / force push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use version traits for most functions in the parser. We need to make conditional branches when processing a YAML version directive but this PR does not include it.