Fix replace/replace! when count is supplied#118
Open
laborg wants to merge 1 commit intoJuliaData:mainfrom
Open
Fix replace/replace! when count is supplied#118laborg wants to merge 1 commit intoJuliaData:mainfrom
laborg wants to merge 1 commit intoJuliaData:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #112
I've now based the implementation on what I found in Set.jl from Julia base and added some tests.
countcan now be supplied also whenCallablesare past.(unrelated test change: I've reduced the loop size for the "getindex with UnitRange" test because this test alone took 2min and I don't see a reason for burning so many CPU cycles for a rather simple test)