Skip to content

Conversation

mbauman
Copy link
Collaborator

@mbauman mbauman commented Dec 11, 2024

  • ensure that iterate generates length(I) values
  • ensure that iterate always matches all of its skips against an index in the axis

addresses the most egregious bad behaviors in #7 and #31. They still don't work as you might hope, but now they throw errors rather than selecting a potentially wrong index.

* ensure that iterate generates `length(I)` values
* ensure that iterate always makes it to the end of all skips

addresses the most egregious bad behaviors in #7 and #31
@mbauman
Copy link
Collaborator Author

mbauman commented Dec 12, 2024

I think this is a good thing to do, whether we add in additional scalar to_indices calls (#41) or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant