Skip to content

deprecate rewind in favor of seekstart #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

deprecate rewind in favor of seekstart #18

merged 2 commits into from
Jul 1, 2025

Conversation

lmiq
Copy link
Collaborator

@lmiq lmiq commented Jul 1, 2025

closes #17

@lmiq lmiq requested a review from ararslan July 1, 2025 00:03
ararslan
ararslan approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, otherwise looks good to me.

@lmiq lmiq merged commit e644de8 into JuliaData:master Jul 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend seekstart from Base instead of defining rewind as a separate function
2 participants
@lmiq @ararslan