Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rownumber #61

Merged
merged 3 commits into from
May 12, 2023
Merged

Add rownumber #61

merged 3 commits into from
May 12, 2023

Conversation

VEZY
Copy link
Contributor

@VEZY VEZY commented Apr 23, 2023

Add rownumber from DataFrames. See #60

@VEZY
Add rownumber
6e36e6a 
Up version
@VEZY VEZY mentioned this pull request Apr 23, 2023
Closed
bkamins
bkamins reviewed Apr 23, 2023
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
bkamins
bkamins approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one small comment.

@codecov
Copy link

codecov bot commented Apr 23, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (7fa794b) 96.36% compared to head (6596edd) 96.36%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files           1        1           
  Lines          55       55           
=======================================
  Hits           53       53           
  Misses          2        2
Impacted Files Coverage Δ
src/DataAPI.jl 96.36% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bkamins
Copy link
Member

bkamins commented Apr 30, 2023

@quinnj, @nalimilan - OK to merge?

nalimilan
nalimilan approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! This is the most tested line of the ecosystem. :-)

@bkamins bkamins merged commit b131356 into JuliaData:main May 12, 2023
@bkamins
Copy link
Member

bkamins commented May 12, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

@nalimilan nalimilan nalimilan approved these changes

@quinnj quinnj Awaiting requested review from quinnj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VEZY @bkamins @nalimilan