fix(jh): honour JULIA_DEPOT_PATH rather than .julia#16
Open
thelonewolf1603 wants to merge 1 commit intomainfrom
Open
fix(jh): honour JULIA_DEPOT_PATH rather than .julia#16thelonewolf1603 wants to merge 1 commit intomainfrom
JULIA_DEPOT_PATH rather than .julia#16thelonewolf1603 wants to merge 1 commit intomainfrom
Conversation
thelonewolf1603
changed the title
JULIA_DEPOT_PATH rather than .julia
vdayanand
requested changes
Feb 6, 2026
| homeDir, err := os.UserHomeDir() | ||
| if err != nil { | ||
| return err | ||
| // Determine Julia depot path |
Member
There was a problem hiding this comment.
Maybe its simpler rely on Base.DEPOT_PATH?. Oops, Didnt realize this was go
vdayanand
reviewed
Feb 6, 2026
Comment on lines
+11
to
+27
| // Determine Julia depot path | ||
| var depotPath string | ||
| if juliaDepot := os.Getenv("JULIA_DEPOT_PATH"); juliaDepot != "" { | ||
| // Use first path from JULIA_DEPOT_PATH (paths are separated by : on Unix, ; on Windows) | ||
| depotPaths := filepath.SplitList(juliaDepot) | ||
| if len(depotPaths) > 0 { | ||
| depotPath = depotPaths[0] | ||
| } | ||
| } | ||
|
|
||
| // Fall back to ~/.julia if JULIA_DEPOT_PATH is not set | ||
| if depotPath == "" { | ||
| homeDir, err := os.UserHomeDir() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get user home directory: %w", err) | ||
| } | ||
| depotPath = filepath.Join(homeDir, ".julia") |
Member
There was a problem hiding this comment.
Can we make this a separate function so it can be reused ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8