fix: gracefully handle problematic application API entries#133
Merged
fix: gracefully handle problematic application API entries#133
Conversation
pfitzseb
reviewed
Feb 4, 2026
| try | ||
| push!(rs, f(x)::T) | ||
| catch e | ||
| @warn error_message exception = ( |
Member
There was a problem hiding this comment.
Can we put this outside of the loop so it only gets printed once per function invocation?
Member
Author
There was a problem hiding this comment.
Technically we could, of course, and then somehow gather up the errors for a single print etc. But I am actually inclined not to add that complexity -- hitting this branch implies a backend issue, and it's actually better if this is annoyingly in the face of the user. We really should not be hitting this branch normally.
pfitzseb
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, when we are not able to parse an entry in the list of applications, package apps or user apps,
JuliaHub.applications()throws, also making it impossible to use the applications that are actually fine. This changes the error handling such that we print a warning for each bad entry, but will still return an array of any of the apps we were able to interpret. This is consistent with how we handle problematic datasets.Relatedly, it turns out we were not running the
test/applications.jltests. Now we do.