Skip to content

fix: gracefully handle problematic application API entries#133

Merged
mortenpi merged 6 commits intomainfrom
mp/applications-list
Feb 5, 2026
Merged

fix: gracefully handle problematic application API entries#133
mortenpi merged 6 commits intomainfrom
mp/applications-list

Conversation

@mortenpi
Copy link
Member

@mortenpi mortenpi commented Feb 4, 2026

Presently, when we are not able to parse an entry in the list of applications, package apps or user apps, JuliaHub.applications() throws, also making it impossible to use the applications that are actually fine. This changes the error handling such that we print a warning for each bad entry, but will still return an array of any of the apps we were able to interpret. This is consistent with how we handle problematic datasets.

Relatedly, it turns out we were not running the test/applications.jl tests. Now we do.

@mortenpi mortenpi requested a review from pfitzseb February 4, 2026 17:27
@mortenpi mortenpi enabled auto-merge (squash) February 4, 2026 17:27
try
push!(rs, f(x)::T)
catch e
@warn error_message exception = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this outside of the loop so it only gets printed once per function invocation?

Copy link
Member Author

@mortenpi mortenpi Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we could, of course, and then somehow gather up the errors for a single print etc. But I am actually inclined not to add that complexity -- hitting this branch implies a backend issue, and it's actually better if this is annoyingly in the face of the user. We really should not be hitting this branch normally.

@mortenpi mortenpi requested a review from pfitzseb February 5, 2026 14:04
@mortenpi mortenpi merged commit 596a219 into main Feb 5, 2026
24 of 25 checks passed
@mortenpi mortenpi deleted the mp/applications-list branch February 5, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants