Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set JULIA_TEST_TIMEOUT_SIGNUM=3 #165

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Set JULIA_TEST_TIMEOUT_SIGNUM=3 #165

wants to merge 4 commits into from

Conversation

staticfloat
Copy link
Member

Let's try to get some coredumps from our timeouts

@DilumAluthge DilumAluthge marked this pull request as draft June 29, 2022 22:52
@DilumAluthge
Copy link
Member

Converting to draft so we don't accidentally merge while we still have a "do not merge" commit.

DilumAluthge
DilumAluthge reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to use SIGSEGV instead of SIGQUIT?

@staticfloat
Copy link
Member Author

Any particular reason to use SIGSEGV instead of SIGQUIT?

Nope, that's a great idea.

@staticfloat staticfloat mentioned this pull request Jun 29, 2022
Draft
@staticfloat
Copy link
Member Author

We're waiting on this until I understand signal handling better, and am able to reliably trigger core dumps on all platforms.

@DilumAluthge DilumAluthge force-pushed the sf/core_o_rama branch 2 times, most recently from f31b72e to e88884b Compare July 10, 2022 09:46
@DilumAluthge
Copy link
Member

Okay, so we made some progress by identifying that macOS was resetting our coredump config on reboot.

I think we also need to change by to using SIGSEGV, because as Jameson said on Slack, Julia intercepts SIGQUIT, and thus SIGQUIT won't trigger core dumps.

@JuliaCI JuliaCI deleted a comment from staticfloat Nov 2, 2022
@DilumAluthge DilumAluthge force-pushed the sf/core_o_rama branch 2 times, most recently from 368ff24 to 03a5c57 Compare November 5, 2022 14:47
@DilumAluthge
Copy link
Member

@staticfloat Can we try to get this in?

@DilumAluthge
Copy link
Member

With JuliaLang/julia#47234, I think that if the SIGSEGV is sent by us via kill, then Julia should hard fail (instead of catching the signal and turning it into a Julia exception), and we should get our desired core dumps.

@staticfloat
Set JULIA_TEST_TIMEOUT_SIGNUM=3 to catch more coredumps
2f312c4 
SIGQUIT generally causes a process to coredump, so let's use that as the
termination signal throughout our test suite.

X-ref: JuliaLang/julia#45864
@staticfloat
[DO NOT MERGE] Use customized julia branch
5d5bfd4
@staticfloat staticfloat changed the title Set JULIA_TEST_TIMEOUT_SIGNUM=11 Set JULIA_TEST_TIMEOUT_SIGNUM=3 Aug 10, 2023
@DilumAluthge DilumAluthge added the DROP COMMITS BEFORE MERGING Some commits need to be dropped before merging label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge left review comments

Assignees
No one assigned
Labels
DROP COMMITS BEFORE MERGING Some commits need to be dropped before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfloat @DilumAluthge