Fix parsing of labeled break statements #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JuliaSyntax parses 'break label' statements where the label name is a keyword like 'error' or 'done', it creates Expr(:error, :label) nodes that look like parse errors but are actually just label references. This was causing false positive parse errors when running Julia 1.11 with JuliaSyntax to parse Julia 1.14+ source code containing constructs like '@Label error begin ... break error ... end'. The fix updates has_embedded_errors() to distinguish between real parse errors (Expr(:error) or Expr(:error, "message")) and false positives (Expr(:error, :symbol) from labeled breaks). Fixes buildkite.com/julialang/julia-master-scheduled/builds/1425#019c1312-26d0-4716-8642-7ac68180293e Co-authored-by: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (96.10%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 96.06% 96.10% +0.03%
==========================================
Files 4 4
Lines 356 359 +3
==========================================
+ Hits 342 345 +3
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
JuliaLang/JuliaSyntax.jl#618 should be the proper fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JuliaSyntax parses 'break label' statements where the label name is a keyword like 'error' or 'done', it creates Expr(:error, :label) nodes that look like parse errors but are actually just label references. This was causing false positive parse errors when running Julia 1.11 with JuliaSyntax to parse Julia 1.14+ source code containing constructs like '@Label error begin ... break error ... end'.
The fix updates has_embedded_errors() to distinguish between real parse errors (Expr(:error) or Expr(:error, "message")) and false positives (Expr(:error, :symbol) from labeled breaks).
Fixes http://buildkite.com/julialang/julia-master-scheduled/builds/1425#019c1312-26d0-4716-8642-7ac68180293e