Detect syntax version from project files to support parsing newer Julia syntax #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jan 26, 2026
Keno
reviewed
Jan 26, 2026
IanButterworth
force-pushed
the
ib/handle_syntax
branch
from
c7445f4 to
8571768
Compare
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (96.06%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 98.36% 96.06% -2.30%
==========================================
Files 4 4
Lines 245 356 +111
==========================================
+ Hits 241 342 +101
- Misses 4 14 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ia syntax When analyzing code coverage, detect the appropriate syntax version by: - Checking Project.toml/JuliaProject.toml for syntax.julia_version or compat.julia - Falling back to VERSION file for Julia's base/ source - Using Base.project_get_syntax_version() when available (Julia 1.14+) This allows Coverage.jl running under Julia 1.11 to correctly parse Julia 1.14+ source code containing features like labeled breaks, by passing the detected syntax version to Meta.parse via the version keyword argument. Co-Authored-By: Claude <noreply@anthropic.com>
This change enables CoverageTools to parse Julia source code using syntax versioning, allowing coverage collection when the runner Julia version differs from the source code version. This fixes coverage jobs that run on Julia 1.11 but need to parse Julia 1.14 code containing features like labeled break/continue statements. Fixes JuliaLang/julia#60826 CoverageTools: Add version-aware parsing using JuliaSyntax This enables CoverageTools running on Julia 1.11 to parse Julia 1.14+ code with labeled breaks. Fixes JuliaLang/julia#60826
Per review feedback: - Default to v"1.14" instead of VERSION since JuliaSyntax maintains backwards compatibility - Remove incorrect compat parsing logic - only respect explicit syntax.julia_version - Keep Base.project_file_load_spec() usage for Julia 1.14+
IanButterworth
force-pushed
the
ib/handle_syntax
branch
from
3f00816 to
d420916
Compare
- Simplify has_embedded_errors() using early returns and any() - Clarify current_line computation (lineoffset + 1) - Add TOML fallback test for Julia < 1.14 syntax version detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version-aware parsing using JuliaSyntax
This PR enables CoverageTools to parse Julia source code across different syntax versions by:
Key Changes:
detect_syntax_version()to automatically detect the appropriate Julia syntax version by:Project.toml/JuliaProject.tomlfor explicitsyntax.julia_versionentriesBase.project_file_load_spec()when available (Julia 1.14+)VERSIONfile for Julia'sbase/source treev"1.14"(JuliaSyntax maintains backwards compatibility)amend_coverage_from_src!()to useJuliaSyntax.parsestmt()with the detected version parameterhas_embedded_errors()helper to detect parse errors in ASTs with proper error reportingWhy This Matters:
This allows CoverageTools running under Julia 1.11 (or any version) to correctly parse Julia 1.14+ source code containing new syntax features like labeled breaks. Since JuliaSyntax provides version-aware parsing independent of the running Julia version, coverage analysis now works seamlessly across version boundaries.
Implementation Details:
Fixes JuliaLang/julia#60826
Developed with Claude