Use trixi_include from TrixiBase.jl
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 96.12% 96.15% +0.02%
==========================================
Files 17 17
Lines 1111 1065 -46
==========================================
- Hits 1068 1024 -44
+ Misses 43 41 -2 ☔ View full report in Codecov by Sentry. |
ranocha
previously approved these changes
Feb 13, 2024
|
Yes. So let's wait for trixi-framework/TrixiBase.jl#13. |
ranocha
reviewed
Feb 14, 2024
Co-authored-by: Hendrik Ranocha <[email protected]>
ranocha
previously approved these changes
Feb 14, 2024
|
It looks like the availability of the new version has not reached all package servers yet. Maybe let's wait a bit and re-trigger CI after a few hours? |
|
I'm currently on my phone. So (I think) I cannot suggest any code change in the App, but the compat bound for TrixiBase.jl should be bumped in the docs directory, too. |
CI is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some utility functions moved to the new package TrixiBase.jl.