Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SummaryCallback #75

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add SummaryCallback #75

merged 2 commits into from
Dec 11, 2023

Conversation

JoshuaLampert
Copy link
Owner

@JoshuaLampert JoshuaLampert commented Dec 11, 2023

Adds a SummaryCallback similar to Trixi.jl that prints the timings and allocations for the different parts of the simulation using TimerOutputs.jl. Unlike Trixi.jl, the SummaryCallback does not print anything at the beginning of a simulation and the output from TimerOutputs.jl is always printed at the end of a simulation without the need to manually call the callback.

Closes #45.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a52454f) 95.91% compared to head (818a82b) 96.11%.

Files Patch % Lines
src/callbacks_step/relaxation.jl 78.57% 3 Missing ⚠️
src/equations/bbm_bbm_1d.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   95.91%   96.11%   +0.20%     
==========================================
  Files          13       14       +1     
  Lines        1052     1081      +29     
==========================================
+ Hits         1009     1039      +30     
+ Misses         43       42       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert merged commit 20d957a into main Dec 11, 2023
12 of 13 checks passed
@JoshuaLampert JoshuaLampert deleted the summarycallback branch December 11, 2023 16:12
@JoshuaLampert JoshuaLampert added the enhancement New feature or request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SummaryCallback
1 participant