Use TestItems.jl #153
Use TestItems.jl #153
Conversation
| change_entropy=-3.1086244689504383e-15) | ||
|
|
||
| @test_allocations(semi, sol, allocs=10_000) | ||
| @test_allocations(semi, sol, allocs=2_000) |
There was a problem hiding this comment.
I needed to increase the allocations from 1_500 to 2_000 for some reason to make the test pass (the number of allocations was 1_920). I have no idea why this was necessary. The same holds for the upwind allocations of the next @testitem.
There was a problem hiding this comment.
Interesting. I also have no immediate idea. Could be caused by less effective constant propagation or something like this 🤷
There was a problem hiding this comment.
Ok, but I think it's fine. It's only marginal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 19 19
Lines 1776 1776
=======================================
Hits 1740 1740
Misses 36 36 ☔ View full report in Codecov by Sentry. |
With the current testing setup it is quite cumbersome to run only certain tests. I usually just commented all the other tests by hand. By using TestItems.jl and TestItemRunner.jl this is much more convenient because single test items can be run separately in VScode. The usual testing workflow using
]teststill works. Additionally, running tests is much faster this way. We also don't need the@trixi_testsetmacro anymore.See also https://www.julia-vscode.org/docs/stable/userguide/testitems/.