Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we define the pretty printing of some functions twice: Once for the$L^2$ , $L^\infty$ and the conservation error) don't have a corresponding function (the lake-at-rest error on the other hand has). Thus, for simplicity, I just kept the current approach for the errors and define a pretty form in visualization.jl for the errors (this means it is redefined for the lake-at-rest error), but reuse the pretty form from the
AnalysisCallback
and once in visualization.jl (and forgot, e.g. ,energy_total_modified
in visualization.jl). In visualization.jl we only have access to the Symbol and not the function since this is what is stored inintegrals(analysis_callback)
, but we can translate it to the function usinggetfield(@__MODULE__, name)
. However, most errors (AnalysisCallback
for the integrals. This meanspretty_form_utf
dispatches a bit strangely on functions and Symbols. I am open for a better suggestion, @ranocha.