-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BBMEquation1D
#150
Add BBMEquation1D
#150
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 97.78% 97.97% +0.19%
==========================================
Files 18 19 +1
Lines 1667 1776 +109
==========================================
+ Hits 1630 1740 +110
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Hendrik Ranocha <[email protected]>
I'm totally confused by this error: https://github.com/JoshuaLampert/DispersiveShallowWater.jl/actions/runs/10811172112/job/29990016675?pr=150#step:7:8511 happening in this line:
Why does it want to convert 3.0 to an Int? And why does this happen all of the sudden (only on Mac)? Any ideas, @ranocha? |
I have no idea - that's very strange indeed |
Now CI passes again 🤷♂️ |
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please find below some comments/questions.
Co-authored-by: Hendrik Ranocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, CI seems to be a bit weird. |
This is a first step towards supporting a few simpler models, cf. #95.