Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BBMEquation1D #150

Merged
merged 39 commits into from
Sep 18, 2024
Merged

Add BBMEquation1D #150

merged 39 commits into from
Sep 18, 2024

Conversation

JoshuaLampert
Copy link
Owner

This is a first step towards supporting a few simpler models, cf. #95.

src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Show resolved Hide resolved
src/equations/equations.jl Show resolved Hide resolved
@JoshuaLampert JoshuaLampert added the enhancement New feature or request label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 99.18699% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.97%. Comparing base (11355c0) to head (256eed5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/equations/bbm_1d.jl 98.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   97.78%   97.97%   +0.19%     
==========================================
  Files          18       19       +1     
  Lines        1667     1776     +109     
==========================================
+ Hits         1630     1740     +110     
+ Misses         37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Owner Author

JoshuaLampert commented Sep 11, 2024

I'm totally confused by this error: https://github.com/JoshuaLampert/DispersiveShallowWater.jl/actions/runs/10811172112/job/29990016675?pr=150#step:7:8511 happening in this line:


Why does it want to convert 3.0 to an Int? And why does this happen all of the sudden (only on Mac)? Any ideas, @ranocha?

@ranocha
Copy link
Collaborator

ranocha commented Sep 11, 2024

I have no idea - that's very strange indeed

@JoshuaLampert
Copy link
Owner Author

I have no idea - that's very strange indeed

Now CI passes again 🤷‍♂️

src/equations/equations.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
JoshuaLampert and others added 4 commits September 15, 2024 12:22
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please find below some comments/questions.

src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/bbm_1d.jl Outdated Show resolved Hide resolved
src/equations/equations.jl Outdated Show resolved Hide resolved
src/equations/equations.jl Outdated Show resolved Hide resolved
src/equations/equations.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert
Copy link
Owner Author

Sorry, CI seems to be a bit weird.

@JoshuaLampert JoshuaLampert enabled auto-merge (squash) September 18, 2024 15:32
@JoshuaLampert JoshuaLampert merged commit 8138b0c into main Sep 18, 2024
12 checks passed
@JoshuaLampert JoshuaLampert deleted the bbm-equation branch September 18, 2024 15:58
@JoshuaLampert JoshuaLampert mentioned this pull request Sep 18, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants