Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on Julia v1.10 #142

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Run CI on Julia v1.10 #142

merged 2 commits into from
Aug 18, 2024

Conversation

JoshuaLampert
Copy link
Owner

Since Julia v1.11 will be out probably soon and v1.10 will be the new LTS, I would like to run CI also on v1.10.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (1d821a7) to head (23f25bc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          20       20           
  Lines        1569     1569           
=======================================
  Hits         1531     1531           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha
Copy link
Collaborator

ranocha commented Aug 18, 2024

Sounds reasonable. However, we still support Julia v1.9 - and I would like to keep it this way unless you have a very good reason not to do so. My motivation for this is mainly that there are people out there who are not power users of Julia like we, so they will likely have older versions of it. I would like to support them. That's something I have experienced with BSeries.jl.

Thus, we could for example keep one job on Julia v1.9 and move the others to Julia v1.10.

@JoshuaLampert
Copy link
Owner Author

Thus, we could for example keep one job on Julia v1.9 and move the others to Julia v1.10.

Sounds good. I added a test, which runs with v1.9 on Ubuntu.

@JoshuaLampert
Copy link
Owner Author

What about the Downgrade job? I would run it on v1.10. Do you agree?

@ranocha
Copy link
Collaborator

ranocha commented Aug 18, 2024

What about the Downgrade job? I would run it on v1.10. Do you agree?

I don't have a strong opinion there. One could argue that the oldest versions of all dependencies will likely be available on the oldest Julia versions, though. But as I said, I'm fine either way

@JoshuaLampert
Copy link
Owner Author

Ok, let's keep it on v1.9 for now.

@JoshuaLampert JoshuaLampert marked this pull request as ready for review August 18, 2024 16:36
@JoshuaLampert JoshuaLampert requested a review from ranocha August 18, 2024 16:45
@JoshuaLampert JoshuaLampert merged commit 2d6a6b8 into main Aug 18, 2024
15 checks passed
@JoshuaLampert JoshuaLampert deleted the test-julia-v1-10 branch August 18, 2024 16:49
@JoshuaLampert
Copy link
Owner Author

Sorry, I mixed up the PRs. I wanted to merge the other one...

@JoshuaLampert
Copy link
Owner Author

Are you fine with this PR @ranocha? If yes, I would create a new release. If not, I would first consider your suggestion before creating a new release.
Sorry again for not waiting for your review 😬

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants