-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reflective boundary conditions for BBMBBMEquations1D
#104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 96.18% 96.17% -0.01%
==========================================
Files 17 17
Lines 1074 1125 +51
==========================================
+ Hits 1033 1082 +49
- Misses 41 43 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This looks quite good to me. And yes, the EOC is reasonable 👍
As a start for supporting reflecting bc, I implemented them for the$p/2 + 1$ for $\eta$ and $p$ for $v$ , which is expected due to the reduced order at the boundary, right @ranocha?
BBMBBMEquations1D
as proposed in H. Ranocha, D. Mitsotakis, D. Ketcheson, A Broad Class of Conservative Numerical Methods for Dispersive Wave Equations (2021).Convergence study looks fine, I think. We get something like
p = 2:
p = 4:
p = 6: