Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in convergence_test #102

Merged
merged 3 commits into from
May 5, 2024
Merged

Conversation

JoshuaLampert
Copy link
Owner

The mean EOC was not printed below the other EOCs. This PR fixes this.

@JoshuaLampert JoshuaLampert enabled auto-merge (squash) May 4, 2024 14:24
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (e6884c1) to head (8b0cfbc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          17       17           
  Lines        1074     1074           
=======================================
  Hits         1033     1033           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Owner Author

I needed to soften one tolerance to make the macOS test run successfully. This is because macOS-latest now points to macOS 14, I guess.

@JoshuaLampert JoshuaLampert requested a review from ranocha May 4, 2024 16:15
@JoshuaLampert
Copy link
Owner Author

macos-latest is just annoying. Thus I switched back to macos-13.

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoshuaLampert JoshuaLampert merged commit e8f2734 into main May 5, 2024
14 checks passed
@JoshuaLampert JoshuaLampert deleted the spacing-convergence-test branch May 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants