Skip to content

Commit

Permalink
Fix upwind discretization for Svärd-Kalisch equations
Browse files Browse the repository at this point in the history
  • Loading branch information
@JoshuaLampert
JoshuaLampert committed Dec 10, 2024
1 parent 5ea9507 commit 4d1cc6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/equations/svaerd_kalisch_1d.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ function rhs!(dq, q, t, mesh, equations::SvaerdKalischEquations1D,
mul!(v_x, D1_central, v)
mul!(eta_x_upwind, D1.plus, eta)
@.. tmp1 = alpha_hat * eta_x_upwind
mul!(alpha_eta_x_x, D1_central, tmp1)
mul!(alpha_eta_x_x, D1.minus, tmp1)
@.. tmp1 = alpha_hat * alpha_eta_x_x
mul!(y_x, D1.minus, tmp1)
@.. v_y_x = v * y_x
Expand Down

2 comments on commit 4d1cc6c

@ranocha
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make a new release already including this? Or is your other PR basically ready?

@JoshuaLampert
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR is almost ready. The last part I wanted to add is using a Cholesky decomposition. I have implemented that, but currently the errors are too high, see the PR.

Please sign in to comment.