Skip to content

Commit

Permalink
Merge branch 'main' into all-contributors/add-joshuakgoldberg
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaKGoldberg committed Feb 18, 2024
2 parents 82b7189 + 8c454a1 commit c108259
Show file tree
Hide file tree
Showing 8 changed files with 416 additions and 164 deletions.
18 changes: 18 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,24 @@
"contributions": [
"code"
]
},
{
"login": "steveluscher",
"name": "Steven Luscher",
"avatar_url": "https://avatars.githubusercontent.com/u/13243?v=4",
"profile": "https://github.com/steveluscher",
"contributions": [
"ideas"
]
},
{
"login": "hyoban",
"name": "Stephen Zhou",
"avatar_url": "https://avatars.githubusercontent.com/u/38493346?v=4",
"profile": "https://hyoban.cc",
"contributions": [
"code"
]
}
],
"contributorsPerLine": 7,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
- uses: ./.github/actions/prepare
- run: pnpm run test --coverage
- name: Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4

name: Test

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.11.0
20.11.1
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<a href="#contributors" target="_blank">
<!-- prettier-ignore-start -->
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
<img alt="All Contributors: 2 👪" src="https://img.shields.io/badge/all_contributors-2_👪-21bb42.svg" />
<img alt="All Contributors: 4 👪" src="https://img.shields.io/badge/all_contributors-4_👪-21bb42.svg" />
<!-- ALL-CONTRIBUTORS-BADGE:END -->
<!-- prettier-ignore-end -->
</a>
Expand Down Expand Up @@ -59,8 +59,9 @@ This is a release commit. Returning false.
Based on a commit's conventional commit message type:

1. If the type is `feat` `fix`, or `perf`, it's considered "meaningful"
2. If the type is `docs`, `refactor`, `style`, or `test`, it's ignored
3. If the message looks like `v1.2.3`, `chore: release 1.2.3`, or similar, it's considered a "release"
1. If the commit is marked as being a breaking change, either via a `BREAKING CHANGE:` at the start of any commit message lines or via an `!` appended to the type, it's considered "meaningful"
1. If the type is `docs`, `refactor`, `style`, or `test`, it's ignored
1. If the message looks like `v1.2.3`, `chore: release 1.2.3`, or similar, it's considered a "release"

See [`getCommitMeaning`](./src/getCommitMeaning.ts) for the exact logic used.

Expand Down Expand Up @@ -104,6 +105,8 @@ Thanks! 💖
<tr>
<td align="center" valign="top" width="14.28%"><a href="http://www.joshuakgoldberg.com"><img src="https://avatars.githubusercontent.com/u/3335181?v=4?s=100" width="100px;" alt="Josh Goldberg"/><br /><sub><b>Josh Goldberg</b></sub></a><br /><a href="https://github.com/JoshuaKGoldberg/should-semantic-release/commits?author=JoshuaKGoldberg" title="Code">💻</a> <a href="#maintenance-JoshuaKGoldberg" title="Maintenance">🚧</a> <a href="#infra-JoshuaKGoldberg" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#ideas-JoshuaKGoldberg" title="Ideas, Planning, & Feedback">🤔</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://medium.com/@cakeinpanic/latest"><img src="https://avatars.githubusercontent.com/u/588916?v=4?s=100" width="100px;" alt="Katya Pavlenko"/><br /><sub><b>Katya Pavlenko</b></sub></a><br /><a href="https://github.com/JoshuaKGoldberg/should-semantic-release/commits?author=cakeinpanic" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://hyoban.cc"><img src="https://avatars.githubusercontent.com/u/38493346?v=4?s=100" width="100px;" alt="Stephen Zhou"/><br /><sub><b>Stephen Zhou</b></sub></a><br /><a href="https://github.com/JoshuaKGoldberg/should-semantic-release/commits?author=hyoban" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/steveluscher"><img src="https://avatars.githubusercontent.com/u/13243?v=4?s=100" width="100px;" alt="Steven Luscher"/><br /><sub><b>Steven Luscher</b></sub></a><br /><a href="#ideas-steveluscher" title="Ideas, Planning, & Feedback">🤔</a></td>
</tr>
</tbody>
</table>
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"@types/conventional-commits-parser": "^3.0.4",
"@types/eslint": "^8.44.3",
"@types/pkgjs__parseargs": "^0.10.1",
"@typescript-eslint/eslint-plugin": "^6.7.3",
"@typescript-eslint/parser": "^6.7.3",
"@typescript-eslint/eslint-plugin": "^7.0.0",
"@typescript-eslint/parser": "^7.0.0",
"@vitest/coverage-v8": "^1.0.0",
"console-fail-test": "^0.2.3",
"cspell": "^8.0.0",
Expand All @@ -64,12 +64,12 @@
"eslint-plugin-regexp": "^2.0.0",
"eslint-plugin-vitest": "^0.3.1",
"eslint-plugin-yml": "^1.9.0",
"husky": "^8.0.3",
"husky": "^9.0.0",
"jsonc-eslint-parser": "^2.3.0",
"knip": "^3.0.0",
"knip": "^5.0.0",
"lint-staged": "^15.0.0",
"markdownlint": "^0.33.0",
"markdownlint-cli": "^0.38.0",
"markdownlint-cli": "^0.39.0",
"npm-package-json-lint": "^7.0.0",
"npm-package-json-lint-config-default": "^6.0.0",
"prettier": "^3.0.3",
Expand All @@ -83,7 +83,7 @@
"vitest": "^1.0.0",
"yaml-eslint-parser": "^1.2.2"
},
"packageManager": "pnpm@8.14.1",
"packageManager": "pnpm@8.15.3",
"engines": {
"node": ">=18"
},
Expand Down
Loading

0 comments on commit c108259

Please sign in to comment.