chore: update type for conventionalCommitsParser

JoshuaKGoldberg · Feb 23, 2024 · aca626f · aca626f
1 parent dc269d7
commit aca626f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
 	},
 	"devDependencies": {
 		"@release-it/conventional-changelog": "^8.0.0",
-		"@types/conventional-commits-parser": "^3.0.4",
+		"@types/conventional-commits-parser": "^5.0.0",
 		"@types/eslint": "^8.44.3",
 		"@types/pkgjs__parseargs": "^0.10.1",
 		"@typescript-eslint/eslint-plugin": "^7.0.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/getCommitMeaning.ts b/src/getCommitMeaning.ts
@@ -9,11 +9,9 @@ const releaseCommitTester =
 
 export function getCommitMeaning(message: string) {
 	// Some types are always meaningful or ignored, regardless of potentially release-like messages
-	// options from https://github.com/conventional-changelog/conventional-changelog/issues/648#issuecomment-704867077
-	// https://github.com/JoshuaKGoldberg/should-semantic-release/issues/174
 	const { notes, type } = conventionalCommitsParser.sync(message, {
 		breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/,
-	} as object);
+	});
 	if (notes.some((note) => note.title.match(/^BREAKING[ -]CHANGE$/))) {
 		return "meaningful";
 	}