refactor(valid-local-dependency): remove unreachable code

[michaelfaith]

PR Checklist

• Addresses an existing open issue: fixes 🧪 Testing: Missing test coverage in valid-local-dependency for !require.resolve(filePath) #118
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

This change removes an unreachable code block. require.resolve will only return a string, if the file is resolvable, or throw an error if it isn't. There's never a case in which require.resolve would return a falsy value.

Closes #118

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (668eaee) to head (6fafaef).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
+ Coverage   97.86%   98.71%   +0.84%     
==========================================
  Files          19       19              
  Lines        1172     1163       -9     
  Branches      140      139       -1     
==========================================
+ Hits         1147     1148       +1     
+ Misses         25       15      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaKGoldberg]

😎 ezpz