Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sort-collections): should sort overrides #668

Conversation

sasial-dev
Copy link
Contributor

PR Checklist

Overview

Adds overrides to the defaultCollections. Note that tests were not added because dependencies/devDependencies/peerDependencies are currently not tested.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (36e68b7) to head (da24d31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          17       17           
  Lines        1077     1078    +1     
  Branches       98       98           
=======================================
+ Hits         1065     1066    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 18129cd into JoshuaKGoldberg:main Nov 30, 2024
15 checks passed
@sasial-dev sasial-dev deleted the sort-collections/sort-overrides branch November 30, 2024 02:16
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @sasial-dev for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @sasial-dev! 🎉

Copy link

🎉 This is included in version v0.16.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Nov 30, 2024
Adds @sasial-dev as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#668 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: sort-collections should sort overrides dependencies
2 participants