Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blog post on contributing to a create-typescript-app repository #89

Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Walks through the common steps, with links to common online docs.

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joshuakgoldberg-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 2:27pm

@JoshuaKGoldberg JoshuaKGoldberg changed the title filled in remaining todos feat: blog post on citributing to a create-typescript-app repository Oct 12, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: blog post on citributing to a create-typescript-app repository feat: blog post on contributing to a create-typescript-app repository Oct 12, 2023
Copy link
Contributor

@IllusionMH IllusionMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice post!

Copy link
Contributor

@IllusionMH IllusionMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD. Just checked which one is suggested by Git docs, and git switch still (4 year later) has THIS COMMAND IS EXPERIMENTAL. THE BEHAVIOR MAY CHANGE. note. So, looks like, these changes shouldn't be applied, but I leave them and this comment just for your information.


Added couple of suggested edits related to "new" git command switch instead of catch-all checkout.
As post is oriented to novices it might be good opportunity to show new commands which are more explicit about their intent switch/restore (not mentioned in post).
On the other hand - internet will have more posts and SO answers that contain checkout, not only novices would read it and might be confusing for them, and, most importantly, this is your familiar flow so it makes sense to show what you are sure works.

Therefore, I don't expect that this changes would be added.
Here couple of related links:
Highlights in GH blog: https://github.blog/2019-08-16-highlights-from-git-2-23/
Comparison table: https://stackoverflow.com/a/70454786

@IllusionMH
Copy link
Contributor

bibrty butual

is it correct branch? :)

@JoshuaKGoldberg
Copy link
Owner Author

bibrty butual

is it correct branch? :)

hahahaha thanks, nice catch. I'm at the LibertyJS conference right now and https://www.youtube.com/watch?v=W-FbVT4ddZQ keeps coming to mind. Amusing. Thanks for the catch.

This reverts commit b72d817.
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Oct 13, 2023

THIS COMMAND IS EXPERIMENTAL. THE BEHAVIOR MAY CHANGE.

Blurgh, that's frustrating. I do like the changes. But yeah I'l hold off using/teaching them until they're not experimental. 😞

Thanks though!!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6667d14 into main Oct 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the contributing-to-a-create-typescript-app-repository branch October 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Blog post on contributing to create-typescript-app
3 participants