Added Mocha and Sinon framework & spy support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4. This is a rather large change. Instead of directly calling `afterEach` and so on by the detected environment, the environment is treated as a set of "hooks" used by the `cft` driver. This is necessary because different hooks might need to be called by different environments: `before`/`beforeEach` vs. `beforeAll`/`before`, for example. The spy library in use is now also decoupled from the test framework. Mocha sometimes is run with nothing and sometimes is run with Sinon.
added 2 commits
March 1, 2019 15:39
Console methods can't be both library spies and cft registrations. There should be an object of them outside of the methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of frameworks & environments that need to be verified with this change:
Also to do:
This is a rather large change. Instead of directly calling
afterEachand so on by the detected environment, the environment is treated as a set of "hooks" used by thecftdriver. This is necessary because different hooks might need to be called by different environments:before/beforeEachvs.beforeAll/before, for example.The spy library in use is now also decoupled from the test framework. Mocha sometimes is run with nothing and sometimes is run with Sinon.
Fixes #4. Opens #10.