Remove the extension from the filename#118
Open
cristianoteles wants to merge 1 commit intoJosephSilber:masterfrom
Open
Remove the extension from the filename#118cristianoteles wants to merge 1 commit intoJosephSilber:masterfrom
cristianoteles wants to merge 1 commit intoJosephSilber:masterfrom
Conversation
Remove the extension from the filename to route with extension file.
Example: Route::get('manifest.json')
JosephSilber
reviewed
Jul 3, 2024
Owner
JosephSilber
left a comment
There was a problem hiding this comment.
- How will that work with the webserver, which does add it on?
- What's the motivation for this change?
- If we do make this change, it needs tests.
Author
|
Owner
How so? The webserver will look for
I don't understand how that pertains to the discussion at hand. How does the stored extension affect that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the extension from the filename to route with extension file. Example: Route::get('manifest.json')