Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some small tweaks #186

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

some small tweaks #186

wants to merge 3 commits into from

Conversation

symful
Copy link

@symful symful commented Sep 21, 2024

In regards of #185

@symful symful changed the title Add virtual to ValFunction.BindAndCopy some small tweaks Sep 25, 2024
@symful
Copy link
Author

symful commented Sep 25, 2024 •
edited
Loading

Explanations from top to bottom:

  1. Let BindAndCopy overrideable by giving it virtual to let developers make functions perm-binded
  2. Set nextContext.outerVars to the function's outerVars in ManuallyPushCall so the function won't lose variables outside of its scope. Useful if the function is from the MiniScript code and the function uses variables outside of its scope.
  3. Check temps size before fetch the index to not error'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@symful