New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure self to be a RawData object #180

Open

marcgurevitx wants to merge 1 commit into JoeStrout:master from marcgurevitx:fix-rawdata-self-check

Contributor

marcgurevitx commented Aug 4, 2024 •

edited

Loading

In the current C++ implementation of RawData there's a bug: Methods with self param accept anything that has a _handle, even an open file object.

> f = @RawData.byte
> f file.open("x.ms")  // doesn't raise an error
... ///nonsense

This PR makes it raise an index error (just like in Mini Micro).

(edit: corrected the snippet.)


          Ensure self to be a RawData object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet