Added custom strength calculation option to FlutterPasswordStrength c… #10
Conversation
|
I was just thinking of creating a PR for this exact feature. Is there a reason this has not been merged in yet? https://github.com/dropbox/zxcvbn is a good option here for password strength. |
|
Hey I decided to fork instead of creating a PR since it didn't look like JinHoSo was active/merging PRs - you can look at my fork here I actually made this change to use Zxcvbn! but it will take any method for calculating strength. |
whoops forgot to actually commit the change
|
That is great! Did you use the dart implementation that was based off the CoffeeScript version? https://pub.dev/packages/zxcvbn I am a bit surprised to see so few downloads of the dart version. Is there something else widely used? Sometimes I wonder if it is just because the flutter community is small in comparison to other communities. I would love to see the default just use zxcvbn so someone implementing this (lets face it in production) gets something that will protect their user base. |
|
Yep, that's the package I used - I'm guessing it's down to flutter community being small, but still if there's an anyone using passwords in a production flutter app, they should probably opt for zxcvbn no doubt. Out of curiosity, where do you see install counts for a pub.dev package? |
|
They don't show install counts, I mispoke. Just number of likes and some popularity number. I am not sure how they calculate that. I guess they are working on adding that feature still. dart-lang/pub-dev#2714 Appreciate the insight on what you used! |
…onstructor
I added an option that I was looking for - a custom strength calculation algorithm. Not a huge change, it's an extra parameter in the constructor for FlutterPasswordStrength, and if that parameter is null, it falls back on your implementation of
estimateBruteforceStrength. Thanks for the plugin!