feat(client/windows): introduce go plugin to call fetchResource as a library
#2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
approved these changes
Nov 14, 2024
jyyi1
changed the title
fetchResource as a libraryfetchResource as a library
fortuna
approved these changes
Nov 14, 2024
| #include <stdlib.h> // for C.free | ||
|
|
||
| // InvokeGoAPIResult is a struct used to pass result from Go to TypeScript boundary. | ||
| typedef struct InvokeGoAPIResult_t |
There was a problem hiding this comment.
I think you can define this struct in Go instead and only have the include here.
There was a problem hiding this comment.
Do you mean define it as the struct as:
type InvokeGoAPIResult struct {
Output, ErrorJson *C.char
}I'm afraid this is not supported by CGo:
Not all Go types can be mapped to C types in a useful way. Go struct types are not supported; use a C struct type. Go array types are not supported; use a C pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new mechanism for Electron's renderer process to directly call Go functions.
It shows how this works by migrating the
fetchResourcefunction as an example.