Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use Powershell for killing smartdnsblock processes #2258

Merged
merged 2 commits into from
Nov 16, 2024
Merged

fix: don't use Powershell for killing smartdnsblock processes #2258

merged 2 commits into from
Nov 16, 2024

Conversation

ezhevita
Copy link
Contributor

Powershell might not be in the user's PATH and failing to kill smartdnsblock process after stopping Outline will render network interface unusable until either user manually kills the process or the Outline Windows service is stopped.

@ezhevita ezhevita requested a review from a team as a code owner October 23, 2024 23:33
@fortuna fortuna requested a review from jyyi1 October 24, 2024 14:06
jyyi1
jyyi1 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezhevita for the contribution. The code LGTM.

  • TODO: @jyyi1 we need to re-create the binary file from the latest code.

@jyyi1 jyyi1 merged commit 17bd4f1 into Jigsaw-Code:master Nov 16, 2024
18 checks passed
@ezhevita ezhevita deleted the use-native-process-kill branch November 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezhevita @jyyi1