-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/linux): generate Debian package #2255
Conversation
|
||
"deb": { | ||
"depends": [ | ||
"gconf2", "gconf-service", "libnotify4", "libappindicator1", "libxtst6", "libnss3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are electron required dependencies: https://www.electron.build/app-builder-lib.interface.deboptions#depends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add them as comments to the file? Ugh, it's JSON...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, JSON is bad. How about adding the field No, electron will complain about unknown fields."_depends_comment": "there are electron required deps"
?
|
||
"deb": { | ||
"depends": [ | ||
"gconf2", "gconf-service", "libnotify4", "libappindicator1", "libxtst6", "libnss3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add them as comments to the file? Ugh, it's JSON...
"files": [ | ||
"client/electron/linux_proxy_controller/dist", | ||
"client/electron/icons/png", | ||
"client/output/build/linux" | ||
], | ||
"icon": "client/electron/icons/png", | ||
"target": { | ||
"maintainer": "The Outline Authors", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use Jigsaw.
"maintainer": "The Outline Authors", | |
"maintainer": "Jigsaw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Jigsaw LLC
"arch": [ | ||
"x64" | ||
], | ||
"target": "AppImage" | ||
} | ||
}, { | ||
"arch": "x64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support arm as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, we also need to update Go compiler arguments for tun2socks
. (And I don't have a ARM based machine to test) Could we add this later?
Adds support for generating a Debian package (.deb) for Linux Outline Client.
This allows users to install Outline Client via
sudo apt install Outline-Client.deb
. The package installs the client to/opt/Outline
, it also creates a launch shortcut.Uninstalling the package with
sudo apt remove/purge outline-client
removes everything.This PR adds two "name"s as well:
"extraMetadata"."name"
: Sets the apt package name (visible viaapt list | grep outline-client
)."linux"."executableName"
: Sets the executable file name in/opt/Outline/
. The first letter is capitalized ("Outline") to avoid icon conflicts with Ubuntu's default "outline" icon in launch shortcut.TODO