refactor(client/android): move fetching logic from TypeScript to Go #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
force-pushed
the
junyi/fetch-in-go-android
branch
2 times, most recently
from
f9bf4d8
to
b033c7b
Compare
fortuna
reviewed
Oct 24, 2024
| } else if (Action.FETCH_RESOURCE.is(action)) { | ||
| final String url = args.getString(0); | ||
| LOG.fine(String.format(Locale.ROOT, "Fetching resource at %s ...", url)); | ||
| final FetchResourceResult result = Outline.fetchResource(url); |
There was a problem hiding this comment.
This will block. Is that a problem? I'm afraid this will freeze the UI, especially bad on timeouts.
We may need a callback mechanism instead.
There was a problem hiding this comment.
Aha, we both missed Line 192, 😄. All these calls are already executed in the default threadpool.
fortuna
requested changes
Oct 24, 2024
Cuz it's not being merged into |
jyyi1
force-pushed
the
junyi/fetch-in-go-android
branch
from
6a0b588
to
96a64e9
Compare
fortuna
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Fetch Error
Prerequisite: #2220