Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/electron/windows): force eol=crlf for Windows installation scripts #1992

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Apr 22, 2024

This fixes #1988 .

(I guess I will need to renormalize the line endings once it's getting merged?)

@jyyi1 jyyi1 requested a review from a team as a code owner April 22, 2024 21:42
@jyyi1 jyyi1 changed the title fix(client/electron/windows): force crlf line endings for installation scripts fix(client/electron/windows): force eol=crlf for Windows installation scripts Apr 22, 2024
@daniellacosse
Copy link
Contributor

Yeah, don't forget to renormalize!!

@jyyi1 jyyi1 merged commit 1a944d9 into master Apr 22, 2024
25 checks passed
@jyyi1 jyyi1 deleted the junyi/fix-le-for-win branch April 22, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows 11: failed to install outline-tap0 driver
3 participants